Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of MEX best practice #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Initial draft of MEX best practice #23

wants to merge 4 commits into from

Conversation

rpurser47
Copy link
Member

The proposed organization is meant for toolboxes that implement MEX functions using C/ C++/ Fortran for implementing features. They might also interface with external libraries.

@rpurser47 rpurser47 requested review from gulley and bpancras October 23, 2024 19:46
@rpurser47 rpurser47 self-assigned this Oct 23, 2024
@rpurser47
Copy link
Member Author

This will require internal MathWorks review before it's merged into main.

@rpurser47 rpurser47 marked this pull request as ready for review October 23, 2024 19:46
Copy link
Member

@gulley gulley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm glad this is its own standalone document and not part of the main Toolbox Design doc.

At the top, maybe give etymology of MEX as "MATLAB EXecutable file".

"Let's explore the world of MEX integration!" This sounds a little too ChatGPT chirpy.

Maybe mention earlier that the actual compiled MEX files themselves are derived via the build process and so don't even appear in the folder. We only see, for example, subtract.m and subtract.cpp.

We should be clear about the fact that derived files shouldn't be checked into revision control. The whole concept of derived files is alien to a lot of our pure MATLAB users (i.e. they never really trained on any other language or language ecosystem).

Typo? line 47 "mex function" => "MEX function"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants